Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #804

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Minor cleanup #804

merged 2 commits into from
Nov 7, 2024
+31 −81

Conversation

JoshLozensky
Copy link
Contributor

  • Cleaning up/standardizing the test naming
  • Removing unused code
  • Removing unnecessary ToString() calls
  • Added a folder to hold Playwright traces and a .gitignore to never commit those traces

All tests still pass locally.

@JoshLozensky
Minor cleanup
Loading
Loading status checks…
97c12ac
@JoshLozensky
fix trace filename
Loading
Loading status checks…
30fd8cc
jennyf19
jennyf19 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but is it possible to fix the warnings? They show up in the PR in the GitHub UI if you scroll to the bottom.

@JoshLozensky
Copy link
Contributor Author

Not related, but is it possible to fix the warnings? They show up in the PR in the GitHub UI if you scroll to the bottom.

I'll do that in another PR :)

@JoshLozensky JoshLozensky merged commit 56113b0 into master Nov 7, 2024
2 checks passed
@JoshLozensky JoshLozensky deleted the lozensky/CleanupUiTests branch November 7, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshLozensky @jennyf19